Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/12624 )
Change subject: IMPALA-8256: Better error message for ImpalaServicePool::RejectTooBusy() ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/12624/1/be/src/rpc/impala-service-pool.cc File be/src/rpc/impala-service-pool.cc: http://gerrit.cloudera.org:8080/#/c/12624/1/be/src/rpc/impala-service-pool.cc@119 PS1, Line 119: "The service queue is full; it has $3 items; memory " > It's full when either the max queue length or the memory consumption limit If we want to keep the single message then maybe a message like "$0 request on $1 from $2 dropped due to backpressure. The service queue contains $3 items out of a maximum of $4; memory consumption is $5" I suppose if we really wanted to be more precise we could have the caller pass in the exact reason for the rejection. -- To view, visit http://gerrit.cloudera.org:8080/12624 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If0297658acf2b23823dcb7d2bdff5d8e4475bb98 Gerrit-Change-Number: 12624 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Thomas Marshall <tmarsh...@cloudera.com> Gerrit-Comment-Date: Wed, 27 Feb 2019 23:19:27 +0000 Gerrit-HasComments: Yes
