Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/12635 )
Change subject: IMPALA-8254: Fix error when running compute stats with compression_codec set ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/12635/3/be/src/service/query-options.cc File be/src/service/query-options.cc: http://gerrit.cloudera.org:8080/#/c/12635/3/be/src/service/query-options.cc@235 PS3, Line 235: if (iequals(value, "none") || iequals(value, "0")) { > I don't know if it's a big issue, but this will make the operation to be li I think that the current "else if chain" is also O(N), so replacing it with a single pass over VALUES_TO_NAME would not make it worse. I don't think that being O(N) is a big issue if N=10. -- To view, visit http://gerrit.cloudera.org:8080/12635 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2cb546fbd3d2a02e0ed30d85a33a04852bed9dd2 Gerrit-Change-Number: 12635 Gerrit-PatchSet: 3 Gerrit-Owner: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Thu, 28 Feb 2019 16:44:45 +0000 Gerrit-HasComments: Yes
