Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12591 )
Change subject: IMPALA-7972 Detect self-events to avoid unnecessary invalidates ...................................................................... Patch Set 7: Code-Review+2 (4 comments) Thanks for addressing the comments. A few minor comments and then I can submit it for GVO. http://gerrit.cloudera.org:8080/#/c/12591/7/fe/src/main/java/org/apache/impala/catalog/Table.java File fe/src/main/java/org/apache/impala/catalog/Table.java: http://gerrit.cloudera.org:8080/#/c/12591/7/fe/src/main/java/org/apache/impala/catalog/Table.java@629 PS7, Line 629: getTableName getFullName() http://gerrit.cloudera.org:8080/#/c/12591/7/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java: http://gerrit.cloudera.org:8080/#/c/12591/7/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@659 PS7, Line 659: metrics_.getCounter(MetastoreEventsProcessor.NUMBER_OF_TABLE_INVALIDATES).inc(); Can we move this to invalidateCatalogTable() instead of incrementing at all the callers? http://gerrit.cloudera.org:8080/#/c/12591/7/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/12591/7/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@2289 PS7, Line 2289: operation generated event can be skipped as a self-event? http://gerrit.cloudera.org:8080/#/c/12591/7/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@3279 PS7, Line 3279: to skip the event generated by : * this operation same as above. -- To view, visit http://gerrit.cloudera.org:8080/12591 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6db0d7f7fe465158fc8cb9d6b6b57a321827b353 Gerrit-Change-Number: 12591 Gerrit-PatchSet: 7 Gerrit-Owner: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Reviewer: Bharath Krishna <bhar...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Paul Rogers <prog...@cloudera.com> Gerrit-Reviewer: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Comment-Date: Thu, 28 Feb 2019 23:34:30 +0000 Gerrit-HasComments: Yes
