Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12649 )
Change subject: IMPALA-8272: Fix test_catalog_tablesfilesusage failing ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/12649/1/tests/webserver/test_web_pages.py File tests/webserver/test_web_pages.py: http://gerrit.cloudera.org:8080/#/c/12649/1/tests/webserver/test_web_pages.py@325 PS1, Line 325: assert len(high_filecount_tbls) > 0 Should we add a comment that the expected table might not be in the top-n cache by this point and we may or may not find it in the list? We could also do this as a custom cluster test to control what is bubbled up in the cache, but that seems like an overkill to me. The current test walks through the URL and does some sanity checks, which seems like a reasonable coverage to me. -- To view, visit http://gerrit.cloudera.org:8080/12649 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I41cfa59882edafcd5e61d2e119cd8e8bff08e544 Gerrit-Change-Number: 12649 Gerrit-PatchSet: 1 Gerrit-Owner: Yongzhi Chen <yc...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Mon, 04 Mar 2019 17:18:43 +0000 Gerrit-HasComments: Yes
