Hector Acosta has posted comments on this change. ( http://gerrit.cloudera.org:8080/12574 )
Change subject: Add ccache support ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/12574/1/docker/debian7.df File docker/debian7.df: http://gerrit.cloudera.org:8080/#/c/12574/1/docker/debian7.df@43 PS1, Line 43: wget "https://www.samba.org/ftp/ccache/ccache-3.3.3.tar.gz"; && \ > I recommend moving this into a shell script. Done http://gerrit.cloudera.org:8080/#/c/12574/1/init.sh File init.sh: http://gerrit.cloudera.org:8080/#/c/12574/1/init.sh@138 PS1, Line 138: : ${USE_CCACHE=0} : export USE_CCACHE : : : ${CCACHE_MAXSIZE=50G} : export CCACHE_MAXSIZE : : : ${CCACHE_DIR=$SOURCE_DIR/ccache} : export CCACHE_DIR : : # Default ccache_compilercheck is mtime, which considers CC's mtime + size : # to determine if there's a hit. Setting CCACHE_COMPILERCHECK to 'content' : # uses the hash of the compiler instead. : export CCACHE_COMPILERCHECK=${CCACHE_COMPILERCHECK:-content} : : export CCACHE_COMPRESS=1 > Do you think these would be better encapsulated in a .ccache.conf file that I think there's a trade-off here.. If we create and mount a ccache.conf, ccache would only work inside docker. If we create the ccache.conf somewhere in functions.sh it would work both inside and outside of docker, but since someone could have already defined CCACHE_DIR, we'd need to dance around it to prevent overwriting that conf (not sure if this matters in practice). I know being able to run this in the host helped me debugging some problems so i lean towards being able to enable ccache independent of docker. -- To view, visit http://gerrit.cloudera.org:8080/12574 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ieef291d1294a204b0b8da7e7aa4fa642cdd5e144 Gerrit-Change-Number: 12574 Gerrit-PatchSet: 1 Gerrit-Owner: Hector Acosta <hector.aco...@cloudera.com> Gerrit-Reviewer: Hector Acosta <hector.aco...@cloudera.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Comment-Date: Mon, 04 Mar 2019 17:58:54 +0000 Gerrit-HasComments: Yes
