Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/12680 )
Change subject: IMPALA-8279: Revert IMPALA-6658 to avoid ETL performance regression. ...................................................................... Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/12680/1/be/src/util/rle-encoding.h File be/src/util/rle-encoding.h: http://gerrit.cloudera.org:8080/#/c/12680/1/be/src/util/rle-encoding.h@64 PS1, Line 64: For 1 bit-width values, that point is 8 values. They require 2 bytes : /// for both the repeated encoding or the literal encoding. This value can always : /// be computed based on the bit-width. Maybe it could be mentioned that the optimal can be 16/24 in some cases, but we did not implement it because we are unsure about its benefits. -- To view, visit http://gerrit.cloudera.org:8080/12680 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If6bcbaf564fbbe6dc83ba3afc100b4e5ccc7af40 Gerrit-Change-Number: 12680 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Comment-Date: Wed, 06 Mar 2019 18:39:55 +0000 Gerrit-HasComments: Yes
