Attila Jeges has posted comments on this change. ( http://gerrit.cloudera.org:8080/12481 )
Change subject: IMPALA-7368: Add initial support for DATE type ...................................................................... Patch Set 6: > (2 comments) > > Do you mean that, with these code changes, you can scan HBase date > tables? Or that we should have negative tests for HBase? > > I think we should have test coverage but I'm open to splitting that > out into a separate patch if that helps this get in faster. Yes, with these code changes Impala can scan/write HBase DATE tables. At the minimum, DATE-specific tests should be added to hbase-inserts.test, hbase-scan-node.test, hbase-compute-stats-incremental.test and hbase-compute-stats.test. This would also involve adding extra HBASE tables to functional_hbase. I'd rather do this in a separate change. -- To view, visit http://gerrit.cloudera.org:8080/12481 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iea8155ef09557e0afa2f8b2d0b2dc9d0896dc30f Gerrit-Change-Number: 12481 Gerrit-PatchSet: 6 Gerrit-Owner: Attila Jeges <atti...@cloudera.com> Gerrit-Reviewer: Attila Jeges <atti...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Thu, 07 Mar 2019 16:01:56 +0000 Gerrit-HasComments: No
