Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12684 )
Change subject: IMPALA-7917 (Part 3): Decouple Sentry from Impala ...................................................................... Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/12684/5/fe/src/main/java/org/apache/impala/authorization/AuthorizationFactory.java File fe/src/main/java/org/apache/impala/authorization/AuthorizationFactory.java: http://gerrit.cloudera.org:8080/#/c/12684/5/fe/src/main/java/org/apache/impala/authorization/AuthorizationFactory.java@62 PS5, Line 62: */ : AuthorizationManager newAuthorizationManager(FeCatalogManager catalog, : AuthorizationChecker authzChecker); : : /** : * Creates a new instance of {@link AuthorizationManager}. : */ > I have a feeling that this AuthzMgr should be tied to a Catalog and not whe I like the idea of splitting between SentryCatalogdAuthzManager and SentryImpaladAuthzManager. However I don't think taking Catalog is going to be good enough. FeCatalog is another type of Catalog that doesn't actually implement Catalog. Taking FeCatalog is also not a bad idea since depending on the implementation (for example the CatalogdImpl), the catalog instance can change, so we need to use the FeCatalogManager instead. So, I'm thinking of having two methods, one that takes FeCatalogManager and the other one that takes CatalogServiceCatalog. This way the intention is clear one is for impalad and the other one is for catalogd. Let me know what you think. -- To view, visit http://gerrit.cloudera.org:8080/12684 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1a5d3e0a3e86ac2b0329b56247357fca93229dd0 Gerrit-Change-Number: 12684 Gerrit-PatchSet: 7 Gerrit-Owner: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Paul Rogers <prog...@cloudera.com> Gerrit-Comment-Date: Fri, 08 Mar 2019 09:31:20 +0000 Gerrit-HasComments: Yes
