Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12682 )
Change subject: IMPALA-8271: Refactor the use of Thrift enums for query options ...................................................................... Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/12682/2/be/src/service/query-options.cc File be/src/service/query-options.cc: http://gerrit.cloudera.org:8080/#/c/12682/2/be/src/service/query-options.cc@343 PS2, Line 343: {0, "CACHE_LOCAL"}, > I see. There are some other query options where not all values are actually Done. We can actually just pass our own map in GetThriftEnum for the list of valid enum values. http://gerrit.cloudera.org:8080/#/c/12682/2/be/src/service/query-options.cc@365 PS2, Line 365: > Specifying the template does not seem necessary here, as it can be deduced Done -- To view, visit http://gerrit.cloudera.org:8080/12682 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6d747aae2c689765be72e117ce030ce4e3ce4641 Gerrit-Change-Number: 12682 Gerrit-PatchSet: 5 Gerrit-Owner: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Fri, 08 Mar 2019 18:10:19 +0000 Gerrit-HasComments: Yes
