Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12257 )
Change subject: IMPALA-8097: mt_dop for all queries via hidden flag ...................................................................... Patch Set 8: Code-Review+1 (2 comments) Sorry again for the delay. LGTM. I added Bharath and Paul to the reviewer list so they can double check the logic in FE. http://gerrit.cloudera.org:8080/#/c/12257/8//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12257/8//COMMIT_MSG@14 PS8, Line 14: until IMPALA-4224 is implemented. Inserts work without Also, as the way it's implemented now, the memory consumption for broadcast join will scale with MT_DOP, right ? http://gerrit.cloudera.org:8080/#/c/12257/8/be/src/exec/partitioned-hash-join-builder.cc File be/src/exec/partitioned-hash-join-builder.cc: http://gerrit.cloudera.org:8080/#/c/12257/8/be/src/exec/partitioned-hash-join-builder.cc@108 PS8, Line 108: filter_ctxs_.back().filter = state->filter_bank()->RegisterFilter(filter_desc, true); May want to add a reference to IMPALA-4400 which is abput aggregating the filter locally. -- To view, visit http://gerrit.cloudera.org:8080/12257 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I72f0b02a005e8bf22fd17b8fb5aabf8c0d9b6b15 Gerrit-Change-Number: 12257 Gerrit-PatchSet: 8 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Mon, 11 Mar 2019 22:44:56 +0000 Gerrit-HasComments: Yes
