Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/12730 )
Change subject: IMPALA-337: Add support for POST to the webserver ...................................................................... Patch Set 2: Code-Review+1 (2 comments) LGTM http://gerrit.cloudera.org:8080/#/c/12730/2/be/src/util/webserver.cc File be/src/util/webserver.cc: http://gerrit.cloudera.org:8080/#/c/12730/2/be/src/util/webserver.cc@450 PS2, Line 450: // TODO(wdb): for this and other HTTP requests, we should log the What does wdb mean here? http://gerrit.cloudera.org:8080/#/c/12730/2/tests/custom_cluster/test_web_pages.py File tests/custom_cluster/test_web_pages.py: http://gerrit.cloudera.org:8080/#/c/12730/2/tests/custom_cluster/test_web_pages.py@49 PS2, Line 49: response = requests.post("http://localhost:25000/pprof/symbol";, post_content) Is it possible at this stage to have a test that shows a successful POST? -- To view, visit http://gerrit.cloudera.org:8080/12730 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3bd3ecfab53263c13a4509c278569302c9901abb Gerrit-Change-Number: 12730 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Comment-Date: Tue, 12 Mar 2019 18:53:17 +0000 Gerrit-HasComments: Yes
