Hector Acosta has posted comments on this change. (
http://gerrit.cloudera.org:8080/12726 )
Change subject: Use test -x to check for ntp-wait
......................................................................
Patch Set 1:
> This looks good to me. Quick question: Is this a cosmetic issue or
> is there an actual failure case? I'm wondering if we want a JIRA
> for this. If it is cosmetic, then I think we can skip the JIRA.
There's a failure case:
ntp-wait runs `/usr/sbin/ntpq -c "rv 0"` regardless of whether --help is used
or not.. Its exit status depends on the output of ntpq.
So for example:
[root@8280aa22322d /]# ntp-wait --help ; echo $?
/usr/sbin/ntp-wait version [unknown] calling Getopt::Std::getopts (version 1.07
[paranoid]),
running under Perl version 5.16.3.
Usage: ntp-wait [-OPTIONS [-MORE_OPTIONS]] [--] [PROGRAM_ARG1 ...]
The following single-character options are accepted:
With arguments: -n -s
Boolean (without arguments): -v
Options may be merged together. -- stops processing of options.
Space is not required between options and their arguments.
[Now continuing due to backward compatibility and excessive paranoia.
See 'perldoc Getopt::Std' about $Getopt::Std::STANDARD_HELP_VERSION.]
1
[root@8280aa22322d /]# ntpd
[root@8280aa22322d /]# ntp-wait --help ; echo $?
/usr/sbin/ntp-wait version [unknown] calling Getopt::Std::getopts (version 1.07
[paranoid]),
running under Perl version 5.16.3.
Usage: ntp-wait [-OPTIONS [-MORE_OPTIONS]] [--] [PROGRAM_ARG1 ...]
The following single-character options are accepted:
With arguments: -n -s
Boolean (without arguments): -v
Options may be merged together. -- stops processing of options.
Space is not required between options and their arguments.
[Now continuing due to backward compatibility and excessive paranoia.
See 'perldoc Getopt::Std' about $Getopt::Std::STANDARD_HELP_VERSION.]
0
It also looks like --help is simply ignored.
--
To view, visit http://gerrit.cloudera.org:8080/12726
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I53c63dfa651ac242050171da70540d24c4caf32c
Gerrit-Change-Number: 12726
Gerrit-PatchSet: 1
Gerrit-Owner: Hector Acosta <hector.aco...@cloudera.com>
Gerrit-Reviewer: Hector Acosta <hector.aco...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com>
Gerrit-Comment-Date: Wed, 13 Mar 2019 20:05:36 +0000
Gerrit-HasComments: No
