Anonymous Coward (474) has posted comments on this change. ( http://gerrit.cloudera.org:8080/12683 )
Change subject: Prototype for a remote read byte cache. ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/12683/1/be/src/util/cache.cc File be/src/util/cache.cc: http://gerrit.cloudera.org:8080/#/c/12683/1/be/src/util/cache.cc@81 PS1, Line 81: madvise(addr, buffer_size_, MADV_DONTDUMP) Should we also expose some configuration flags that allow the user to specify madvise options related to read ahead (MADV_NORMAL vs MADV_SEQUENTIAL vs MADV_RANDOM vs MADV_WILLNEED)? Even if we don't want to expose this config publicly in the final version, it might be useful in a prototype to allow experimenting with different kernel readahead policies. -- To view, visit http://gerrit.cloudera.org:8080/12683 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic312b0f7ac7875e00a3855ef21dce5b8a9aa67c5 Gerrit-Change-Number: 12683 Gerrit-PatchSet: 1 Gerrit-Owner: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Anonymous Coward (474) Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Wed, 13 Mar 2019 21:46:39 +0000 Gerrit-HasComments: Yes
