Hello Michael Ho, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12746 to look at the new patch set (#2). Change subject: IMPALA-8299: Fix crash in GroupingAggregator on uninited hash table ...................................................................... IMPALA-8299: Fix crash in GroupingAggregator on uninited hash table If HashTable::Init() fails, in some cases we may try to call HashTable::Close() on the table in GroupingAggregator::Close(), which can cause a crash. The solution is to set the hash table to a nullptr if Init() fails. The patch also fixes a potential issue where HashTable::Init() doesn't set its out parameter if Suballocator::Allocate fails. I also verified that the other use of HashTable, PhjBuilder, handles this case correctly. Testing: - Manually verified that the crash no longer occurs if HashTable::Init fails. Change-Id: I381657c43f93eb4871b93d54532cb886198fd0b2 --- M be/src/exec/grouping-aggregator-partition.cc M be/src/exec/hash-table.cc 2 files changed, 7 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/46/12746/2 -- To view, visit http://gerrit.cloudera.org:8080/12746 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I381657c43f93eb4871b93d54532cb886198fd0b2 Gerrit-Change-Number: 12746 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>