Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12757 )
Change subject: NOT FOR REVIEW: Copy over kudu's gutil ...................................................................... Patch Set 1: (7 comments) http://gerrit.cloudera.org:8080/#/c/12757/1/be/src/gutil/port.h File be/src/gutil/port.h: http://gerrit.cloudera.org:8080/#/c/12757/1/be/src/gutil/port.h@1177 PS1, Line 1177: // Enable UnalignedLoad and UnalignedStore for numeric types (floats and ints) including int128. line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/12757/1/be/src/gutil/stringprintf.h File be/src/gutil/stringprintf.h: http://gerrit.cloudera.org:8080/#/c/12757/1/be/src/gutil/stringprintf.h@44 PS1, Line 44: extern std::string StringPrintfVector(const char* format, const std::vector<std::string>& v); line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/12757/1/be/src/gutil/strings/numbers.cc File be/src/gutil/strings/numbers.cc: http://gerrit.cloudera.org:8080/#/c/12757/1/be/src/gutil/strings/numbers.cc@1075 PS1, Line 1075: static_cast<unsigned __int128>(10000000000) * static_cast<unsigned __int128>(10000000000); line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/12757/1/be/src/gutil/strings/serialize.h File be/src/gutil/strings/serialize.h: http://gerrit.cloudera.org:8080/#/c/12757/1/be/src/gutil/strings/serialize.h@324 PS1, Line 324: std::string DictionaryInt32Encode(const std::unordered_map<std::string, int32>* dictionary); line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/12757/1/be/src/gutil/strings/serialize.h@325 PS1, Line 325: std::string DictionaryInt64Encode(const std::unordered_map<std::string, int64>* dictionary); line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/12757/1/be/src/gutil/strings/serialize.h@326 PS1, Line 326: std::string DictionaryDoubleEncode(const std::unordered_map<std::string, double>* dictionary); line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/12757/1/be/src/gutil/walltime.h File be/src/gutil/walltime.h: http://gerrit.cloudera.org:8080/#/c/12757/1/be/src/gutil/walltime.h@130 PS1, Line 130: return thread_info_data.user_time.seconds * 1000000 + thread_info_data.user_time.microseconds; line too long (96 > 90) -- To view, visit http://gerrit.cloudera.org:8080/12757 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6fd736e3d81f5e925f105dc9ab24955b657b7200 Gerrit-Change-Number: 12757 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Thu, 14 Mar 2019 22:32:46 +0000 Gerrit-HasComments: Yes
