Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12730 )
Change subject: IMPALA-337: Add support for POST to the webserver ...................................................................... IMPALA-337: Add support for POST to the webserver In order to support the TraceEvent path handlers from Kudu (and other functionality like pprof symbolization), the webserver needs to support HTTP POST. This changes the signature for HTTP handler callbacks to take a 'WebRequest' struct instead of a simple map of arguments. This struct exposes the request type, POST data, and unparsed query strings, enabling the callbacks to handle POSTs. The struct itself is imported from Kudu's webserver code, so we can start to share utility HTTP handlers (eg pprof or tracing) more easily between Kudu and Impala. The maximum length of a POST request is limited by the new webserver_max_post_length_bytes parameter, which defaults to 1MB. This patch was written by Todd Lipcon, based on code from Kudu. Testing: - Added a test for too big POSTs to custom_cluster/test_web_pages.py - Verifies the existing core tests pass Change-Id: I3bd3ecfab53263c13a4509c278569302c9901abb Reviewed-on: http://gerrit.cloudera.org:8080/12730 Reviewed-by: Todd Lipcon <t...@apache.org> Tested-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com> --- M be/src/catalog/catalog-server.cc M be/src/catalog/catalog-server.h M be/src/rpc/rpc-trace.cc M be/src/service/impala-http-handler.cc M be/src/service/impala-http-handler.h M be/src/statestore/statestore.cc M be/src/statestore/statestore.h M be/src/util/default-path-handlers.cc M be/src/util/default-path-handlers.h M be/src/util/logging-support.cc M be/src/util/metrics.cc M be/src/util/metrics.h M be/src/util/pprof-path-handlers.cc M be/src/util/thread.cc M be/src/util/webserver-test.cc M be/src/util/webserver.cc M be/src/util/webserver.h M tests/custom_cluster/test_web_pages.py 18 files changed, 251 insertions(+), 147 deletions(-) Approvals: Todd Lipcon: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/12730 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I3bd3ecfab53263c13a4509c278569302c9901abb Gerrit-Change-Number: 12730 Gerrit-PatchSet: 5 Gerrit-Owner: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
