Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12799 )
Change subject: IMPALA-6988: Implement ALTER TABLE/VIEW SET OWNER ...................................................................... Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/12799/1/fe/src/test/java/org/apache/impala/analysis/AuthorizationStmtTest.java File fe/src/test/java/org/apache/impala/analysis/AuthorizationStmtTest.java: http://gerrit.cloudera.org:8080/#/c/12799/1/fe/src/test/java/org/apache/impala/analysis/AuthorizationStmtTest.java@1842 PS1, Line 1842: .error(alterError("functional.alltypes_view"), onDatabase("functional", allExcept( line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/12799/1/fe/src/test/java/org/apache/impala/analysis/ParserTest.java File fe/src/test/java/org/apache/impala/analysis/ParserTest.java: http://gerrit.cloudera.org:8080/#/c/12799/1/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@3822 PS1, Line 3822: ParserError(String.format("ALTER %s %s SET OWNER ROLE %s", type, invalid, invalid)); line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/12799/1/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@3823 PS1, Line 3823: ParserError(String.format("ALTER %s %s SET OWNER USER %s", type, invalid, invalid)); line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/12799/1/tests/metadata/test_ddl_base.py File tests/metadata/test_ddl_base.py: http://gerrit.cloudera.org:8080/#/c/12799/1/tests/metadata/test_ddl_base.py@99 PS1, Line 99: " flake8: E121 continuation line under-indented for hanging indent http://gerrit.cloudera.org:8080/#/c/12799/1/tests/metadata/test_ddl_base.py@127 PS1, Line 127: d flake8: E303 too many blank lines (2) -- To view, visit http://gerrit.cloudera.org:8080/12799 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: 2.x Gerrit-MessageType: comment Gerrit-Change-Id: Ia1b75b1590b16eb0c2ba326d07ee3fd9897c27d1 Gerrit-Change-Number: 12799 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Wed, 20 Mar 2019 02:05:36 +0000 Gerrit-HasComments: Yes
