Hector Acosta has posted comments on this change. ( http://gerrit.cloudera.org:8080/12810 )
Change subject: Add documentation for docker-based toolchain builds ...................................................................... Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/12810/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12810/1//COMMIT_MSG@7 PS1, Line 7: based t > maybe "based" ? Done http://gerrit.cloudera.org:8080/#/c/12810/1//COMMIT_MSG@10 PS1, Line 10: ie > nit: typo Done http://gerrit.cloudera.org:8080/#/c/12810/1/docker/README.md File docker/README.md: http://gerrit.cloudera.org:8080/#/c/12810/1/docker/README.md@18 PS1, Line 18: committe > typo: committed Done http://gerrit.cloudera.org:8080/#/c/12810/1/docker/README.md@26 PS1, Line 26: ubunt > typo: ubuntu Done http://gerrit.cloudera.org:8080/#/c/12810/1/docker/README.md@35 PS1, Line 35: it is possible to specify urls in the DISTROS : make variable. > Does this mean that specifying this URL would cause the Docker images to be Roughly yes. Except that right now, the Makefile assumes that the images have already been built (if the images do not exist, the build procedure fails.) -- To view, visit http://gerrit.cloudera.org:8080/12810 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id971bda58d537fa15ec63004f744d3f730bad170 Gerrit-Change-Number: 12810 Gerrit-PatchSet: 2 Gerrit-Owner: Hector Acosta <hector.aco...@cloudera.com> Gerrit-Reviewer: Hector Acosta <hector.aco...@cloudera.com> Gerrit-Reviewer: Laszlo Gaal <laszlo.g...@cloudera.com> Gerrit-Reviewer: Thomas Marshall <tmarsh...@cloudera.com> Gerrit-Comment-Date: Wed, 20 Mar 2019 17:14:30 +0000 Gerrit-HasComments: Yes
