Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/12632 )
Change subject: IMPALA-8100: Add initial support for Ranger ...................................................................... Patch Set 17: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/12632/16/fe/src/main/java/org/apache/impala/authorization/ranger/RangerAuthorizationChecker.java File fe/src/main/java/org/apache/impala/authorization/ranger/RangerAuthorizationChecker.java: http://gerrit.cloudera.org:8080/#/c/12632/16/fe/src/main/java/org/apache/impala/authorization/ranger/RangerAuthorizationChecker.java@72 PS16, Line 72: // Hive service definition does not have a concept of server. So we define : // server to mean all access to all resource sets. > It would be good if Hive could support it, but that might actually be a big k. Let's come back to this at some point... I can also see the argument that those things may be better off living in a separate Impala-specific service, if it's possible to have a single plugin authorize against two service models. Or, maybe those things would be better off actually passed as a config flag to the impala cluster itself at startup time rather than being centrally administrated, because they are more about service administration than about the underlying data. (eg in a multi-cluster environment, if I "own" an impalad cluster, I should be able to shut it down, but that doesn't imply any permission for me to access any data) -- To view, visit http://gerrit.cloudera.org:8080/12632 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8cad9e609d20aae1ff645c84fd58a02afee70276 Gerrit-Change-Number: 12632 Gerrit-PatchSet: 17 Gerrit-Owner: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Austin Nobis <ano...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Paul Rogers <prog...@cloudera.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Thu, 21 Mar 2019 04:18:23 +0000 Gerrit-HasComments: Yes
