Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12781 )
Change subject: IMPALA-8317: Add support for list type flags in Impala shell config file ...................................................................... IMPALA-8317: Add support for list type flags in Impala shell config file This patch adds support for list type flags in Impala shell config file, i.e. those that use action="append", such as --var and --query_option. To make it less error-prone, this patch also updates the logic for bool flags in the config file to also look at the correct type from the argument parser instead of relying on whether or not the default values are set in impala_shell_config_defaults.py. Testing: - Added a new test for list type flags - Ran all shell E2E tests Change-Id: I824ca15b4e1064a391b13deef9cecd34c928ef73 Reviewed-on: http://gerrit.cloudera.org:8080/12781 Reviewed-by: Fredy Wijaya <fwij...@cloudera.com> Tested-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com> --- M shell/impala_shell.py M shell/option_parser.py M tests/shell/good_impalarc M tests/shell/test_shell_commandline.py M tests/shell/test_shell_interactive.py 5 files changed, 59 insertions(+), 11 deletions(-) Approvals: Fredy Wijaya: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/12781 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I824ca15b4e1064a391b13deef9cecd34c928ef73 Gerrit-Change-Number: 12781 Gerrit-PatchSet: 12 Gerrit-Owner: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Anonymous Coward (395) Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
