Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12837 )
Change subject: IMPALA-8332: Remove Impala Shell warnings part 1 ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/12837/1/shell/TSSLSocketWithWildcardSAN.py File shell/TSSLSocketWithWildcardSAN.py: http://gerrit.cloudera.org:8080/#/c/12837/1/shell/TSSLSocketWithWildcardSAN.py@45 PS1, Line 45: if validate: : cert_reqs = ssl.CERT_REQUIRED : else: : cert_reqs = ssl.CERT_NONE nit: it's more Pythonic to do cert_reqs = ssl.CERT_REQUIRED if validate else ssl.CERT_NONE -- To view, visit http://gerrit.cloudera.org:8080/12837 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I31f9a0bb12ca6a1da9129eacd29ac105b883e01b Gerrit-Change-Number: 12837 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Zoram Thanga <zo...@cloudera.com> Gerrit-Comment-Date: Fri, 22 Mar 2019 18:15:56 +0000 Gerrit-HasComments: Yes
