Quanlong Huang has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12806 )
Change subject: Fix zsh issue in set-pythonpath.sh ...................................................................... Fix zsh issue in set-pythonpath.sh When sourcing set-pythonpath.sh on a partially checked out or partially built source tree (e.g. when running perf tests or after build errors), an empty shell glob pattern would return an empty list in bash but trigger an error in zsh. This would lead to the script aborting before exporting the PYTHONPATH variable, leading to hard to debug test failures. To fix this, this change replaces the glob pattern with a call to 'find', which works independent of the shell being used. Although we would only hit this in somewhat contrived edge cases, it seems beneficial to make the code work as expected on all shells. Testing: I built Impala, sourced impala-config.sh in both new zsh and bash shells, and observed that PYTHONPATH was exported correctly. Then I deleted the .egg files in question, sourced impala-config.sh in both new zsh and bash shells, and observed that PYTHONPATH was exported correctly, too. Change-Id: Ia902891ab36f3aee96a53aa105cc5775321d0058 Reviewed-on: http://gerrit.cloudera.org:8080/10901 Reviewed-by: Lars Volker <l...@cloudera.com> Tested-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Reviewed-on: http://gerrit.cloudera.org:8080/12806 Reviewed-by: Tim Armstrong <tarmstr...@cloudera.com> --- M bin/set-pythonpath.sh 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Impala Public Jenkins: Verified Tim Armstrong: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/12806 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: 2.x Gerrit-MessageType: merged Gerrit-Change-Id: Ia902891ab36f3aee96a53aa105cc5775321d0058 Gerrit-Change-Number: 12806 Gerrit-PatchSet: 2 Gerrit-Owner: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>
