Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12844 )
Change subject: IMPALA-8340: Rewrite fixes in IMPALA-8317 and IMPALA-8337 ...................................................................... Patch Set 4: > Patch Set 4: Code-Review+2 > > Hmm, my understanding was that we would not need duplicate keys if var would > get its own config group. > impala-shell --var=msg1=hello --var=msg2=hello > could be expressed by: > [impala.var] > msg1=hello > msg2=world Ah, I see what you mean. -- To view, visit http://gerrit.cloudera.org:8080/12844 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifc0bf391ba26cf5a34f622a4157d7287453cc539 Gerrit-Change-Number: 12844 Gerrit-PatchSet: 4 Gerrit-Owner: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Mon, 25 Mar 2019 23:11:36 +0000 Gerrit-HasComments: No
