Hello Joe McDonnell, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12858
to look at the new patch set (#2).
Change subject: IMPALA-8359: Fix coverage data generation for impalads
......................................................................
IMPALA-8359: Fix coverage data generation for impalads
impala::InitCommonRuntime() sets a signal handler for SIGTERM.
It calls _exit(0) which causes normal program termination without
cleaning up, i.e. no destructors are called etc.
Gcov writes the coverage data in this cleanup phase, so calling
_exit() prevents flushing coverage data.
Now the '-codecoverage' flag also defines a macro named
CODE_COVERAGE_ENABLED. If this macro is defined we call exit()
instead of _exit(), because exit() cleans up the process properly.
I tested manually.
Change-Id: I9be1e1e73b6cfc3557077f763aee4dbfcc7a2d27
---
M be/CMakeLists.txt
M be/src/common/init.cc
2 files changed, 7 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/58/12858/2
--
To view, visit http://gerrit.cloudera.org:8080/12858
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9be1e1e73b6cfc3557077f763aee4dbfcc7a2d27
Gerrit-Change-Number: 12858
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <borokna...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com>
