Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12859 )
Change subject: IMPALA-8362: Increase authorization test coverage with local catalog ...................................................................... Patch Set 2: Code-Review+2 (4 comments) http://gerrit.cloudera.org:8080/#/c/12859/2/tests/authorization/test_grant_revoke.py File tests/authorization/test_grant_revoke.py: http://gerrit.cloudera.org:8080/#/c/12859/2/tests/authorization/test_grant_revoke.py@112 PS2, Line 112: global_catalog Don't think the code refers to it as global_catalog. Call it default_catalog or v1_catalog or something? http://gerrit.cloudera.org:8080/#/c/12859/2/tests/authorization/test_grant_revoke.py@113 PS2, Line 113: non-local catalog If local catalog becomes default, this is stale. May be can just call default? http://gerrit.cloudera.org:8080/#/c/12859/2/tests/authorization/test_grant_revoke.py@118 PS2, Line 118: 1 nit: true (to be consistent with other tests) http://gerrit.cloudera.org:8080/#/c/12859/2/tests/authorization/test_grant_revoke.py@120 PS2, Line 120: 1 same. -- To view, visit http://gerrit.cloudera.org:8080/12859 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1efc56709bc3da16978589e20d7c611db4fa271a Gerrit-Change-Number: 12859 Gerrit-PatchSet: 2 Gerrit-Owner: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Tue, 26 Mar 2019 17:42:45 +0000 Gerrit-HasComments: Yes
