Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/12672 )
Change subject: IMPALA-8143: Enhance DoRpcWithRetry(). ...................................................................... Patch Set 3: Code-Review+1 (4 comments) Looks good, thanks for doing this. +1 for now to give Michael a change to take a look http://gerrit.cloudera.org:8080/#/c/12672/3/be/src/rpc/rpc-mgr.h File be/src/rpc/rpc-mgr.h: http://gerrit.cloudera.org:8080/#/c/12672/3/be/src/rpc/rpc-mgr.h@29 PS3, Line 29: using kudu::MonoDelta; please don't use 'using' in header files http://gerrit.cloudera.org:8080/#/c/12672/3/be/src/rpc/rpc-mgr.h@181 PS3, Line 181: noop maybe name this something more descriptive, eg. logging_noop() and/or mention in the comment that this is used as the logging function http://gerrit.cloudera.org:8080/#/c/12672/3/be/src/rpc/rpc-mgr.inline.h File be/src/rpc/rpc-mgr.inline.h: http://gerrit.cloudera.org:8080/#/c/12672/3/be/src/rpc/rpc-mgr.inline.h@30 PS3, Line 30: using kudu::MonoDelta; please don't use 'using' in header files http://gerrit.cloudera.org:8080/#/c/12672/3/be/src/rpc/rpc-mgr.inline.h@61 PS3, Line 61: using namespace std remove this -- To view, visit http://gerrit.cloudera.org:8080/12672 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia9693151c35e02235665b3c285a48c585973d390 Gerrit-Change-Number: 12672 Gerrit-PatchSet: 3 Gerrit-Owner: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Thomas Marshall <tmarsh...@cloudera.com> Gerrit-Comment-Date: Tue, 26 Mar 2019 19:04:28 +0000 Gerrit-HasComments: Yes
