Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12916 )
Change subject: IMPALA-8360: Fix race conditions in thread-pool-test ...................................................................... IMPALA-8360: Fix race conditions in thread-pool-test There are race conditions in thread-pool-test between the caller thread and the worker thread. Specifically, in some cases, the worker thread seems to be slow in freeing resources. This can lead to asserts failing because the work item has not been freed or because the submit of a task failed when it should not have. This fixes the race conditions: - It breaks up the existing SynchronousThreadPoolTest into two smaller tests so that the two can't interfere with each other. - It adds the ability to sleep and recheck that the work item has been freed. Testing: - Ran thread-pool-test in a loop for 20k iterations Change-Id: Id2d5f8b677e475d8e9d6b4512e990b20bfbefaf1 Reviewed-on: http://gerrit.cloudera.org:8080/12916 Reviewed-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Tested-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com> --- M be/src/util/thread-pool-test.cc 1 file changed, 16 insertions(+), 1 deletion(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/12916 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Id2d5f8b677e475d8e9d6b4512e990b20bfbefaf1 Gerrit-Change-Number: 12916 Gerrit-PatchSet: 3 Gerrit-Owner: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>
