Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12955 )
Change subject: spill hwm metric ...................................................................... Patch Set 1: (9 comments) http://gerrit.cloudera.org:8080/#/c/12955/1/be/src/runtime/tmp-file-mgr.cc File be/src/runtime/tmp-file-mgr.cc: http://gerrit.cloudera.org:8080/#/c/12955/1/be/src/runtime/tmp-file-mgr.cc@69 PS1, Line 69: const string TMP_FILE_MGR_SCRATCH_SPACE_BYTES_USED_HIGH_WATER_MARK = line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/12955/1/be/src/runtime/tmp-file-mgr.cc@147 PS1, Line 147: metrics->AddHWMGauge(TMP_FILE_MGR_SCRATCH_SPACE_BYTES_USED_HIGH_WATER_MARK, 0); line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/12955/1/be/src/runtime/tmp-file-mgr.cc@147 PS1, Line 147: metrics->AddHWMGauge(TMP_FILE_MGR_SCRATCH_SPACE_BYTES_USED_HIGH_WATER_MARK, 0); tab used for whitespace http://gerrit.cloudera.org:8080/#/c/12955/1/be/src/runtime/tmp-file-mgr.cc@148 PS1, Line 148: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/12955/1/be/src/util/metrics.h File be/src/util/metrics.h: http://gerrit.cloudera.org:8080/#/c/12955/1/be/src/util/metrics.h@258 PS1, Line 258: : IntGauge(metric_def, initial_value), hwm_value_(initial_value) {} line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/12955/1/be/src/util/metrics.h@258 PS1, Line 258: : IntGauge(metric_def, initial_value), hwm_value_(initial_value) {} tab used for whitespace http://gerrit.cloudera.org:8080/#/c/12955/1/be/src/util/metrics.h@268 PS1, Line 268: /// Atomically sets the current value and atomically sets the high water mark value. line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/12955/1/be/src/util/metrics.h@272 PS1, Line 272: } line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/12955/1/be/src/util/metrics.h@293 PS1, Line 293: line has trailing whitespace -- To view, visit http://gerrit.cloudera.org:8080/12955 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iafaadaa8a34e57725eafff124858b9b3991e1ce6 Gerrit-Change-Number: 12955 Gerrit-PatchSet: 1 Gerrit-Owner: Abhishek Rawat <ara...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Sun, 07 Apr 2019 21:03:00 +0000 Gerrit-HasComments: Yes
