Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12885 )
Change subject: IMPALA-8371: Return appropriate error code for unified backend tests ...................................................................... Patch Set 5: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/12885/2/bin/gen-backend-test-script.py File bin/gen-backend-test-script.py: http://gerrit.cloudera.org:8080/#/c/12885/2/bin/gen-backend-test-script.py@37 PS2, Line 37: """).lstrip() > It gets rid of a leading blank line. Added a comment about it. I see. If you add a "\" at the end of the first line, it'll dedent the rest properly and you shouldn't have a blank line (that seems to be the suggestion of the dedent documentation). http://gerrit.cloudera.org:8080/#/c/12885/5/bin/gen-backend-test-script.py File bin/gen-backend-test-script.py: http://gerrit.cloudera.org:8080/#/c/12885/5/bin/gen-backend-test-script.py@24 PS5, Line 24: # This script is used by the build system and is not intended to be run directly. I'd be inclined to drop the parameter description above and repeat them in the --help section below. The script is not intended to be called manually anyways. Maybe replace with a comment like "for an example usage, see other_file.sh"? -- To view, visit http://gerrit.cloudera.org:8080/12885 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia146d026d42f76d5ea12d92798f299182de03eef Gerrit-Change-Number: 12885 Gerrit-PatchSet: 5 Gerrit-Owner: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Comment-Date: Mon, 08 Apr 2019 16:41:29 +0000 Gerrit-HasComments: Yes
