Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12950 )
Change subject: WIP: Refactor file descriptor loading code ...................................................................... Patch Set 2: (5 comments) refactor generally makes sense to me. http://gerrit.cloudera.org:8080/#/c/12950/2/fe/src/main/java/org/apache/impala/catalog/FileMetadataLoader.java File fe/src/main/java/org/apache/impala/catalog/FileMetadataLoader.java: http://gerrit.cloudera.org:8080/#/c/12950/2/fe/src/main/java/org/apache/impala/catalog/FileMetadataLoader.java@48 PS2, Line 48: Parallel remove? http://gerrit.cloudera.org:8080/#/c/12950/2/fe/src/main/java/org/apache/impala/catalog/FileMetadataLoader.java@49 PS2, Line 49: private static final Configuration CONF = new Configuration(); nit: Use the cached FileSystemUtil.CONF? http://gerrit.cloudera.org:8080/#/c/12950/2/fe/src/main/java/org/apache/impala/catalog/FileMetadataLoader.java@58 PS2, Line 58: stats_ nit: maybe call loadStats_ or something? There are too many stats in the code, hoping the rename clears some ambiguity. http://gerrit.cloudera.org:8080/#/c/12950/2/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java File fe/src/main/java/org/apache/impala/catalog/HdfsTable.java: http://gerrit.cloudera.org:8080/#/c/12950/2/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java@560 PS2, Line 560: Map<Path, FileMetadataLoader> loadersByPath = Maps.newHashMap(); : for (Map.Entry<Path, List<HdfsPartition>> e : partsByPath.entrySet()) { : List<FileDescriptor> oldFds = e.getValue().get(0).getFileDescriptors(); : FileMetadataLoader loader = new FileMetadataLoader(e.getKey(), oldFds, hostIndex_); does it make sense to move the loaders init into ParallelFileMetadata c'tor? http://gerrit.cloudera.org:8080/#/c/12950/2/fe/src/main/java/org/apache/impala/catalog/local/DirectMetaProvider.java File fe/src/main/java/org/apache/impala/catalog/local/DirectMetaProvider.java: http://gerrit.cloudera.org:8080/#/c/12950/2/fe/src/main/java/org/apache/impala/catalog/local/DirectMetaProvider.java@288 PS2, Line 288: fml lol :-) -- To view, visit http://gerrit.cloudera.org:8080/12950 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I59edf493b9ba38be5f556b4795a7684d9c9e3a07 Gerrit-Change-Number: 12950 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Anonymous Coward (486) Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Comment-Date: Mon, 08 Apr 2019 18:23:45 +0000 Gerrit-HasComments: Yes
