Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12282 )
Change subject: IMPALA-6050: Query profiles should indicate storage layer(s) used ...................................................................... Patch Set 6: Code-Review+2 (2 comments) LGTM assuming tests pass. http://gerrit.cloudera.org:8080/#/c/12282/4/fe/src/main/java/org/apache/impala/catalog/FsType.java File fe/src/main/java/org/apache/impala/catalog/FsType.java: http://gerrit.cloudera.org:8080/#/c/12282/4/fe/src/main/java/org/apache/impala/catalog/FsType.java@25 PS4, Line 25: > Moved it to FileSystemUtil.java so all the code is in one place. The use of Thanks for the explanation, yeah that makes a lot of sense. http://gerrit.cloudera.org:8080/#/c/12282/4/testdata/workloads/functional-planner/queries/PlannerTest/scan-node-fs-scheme.test File testdata/workloads/functional-planner/queries/PlannerTest/scan-node-fs-scheme.test: http://gerrit.cloudera.org:8080/#/c/12282/4/testdata/workloads/functional-planner/queries/PlannerTest/scan-node-fs-scheme.test@22 PS4, Line 22: S3 partitions=1/0 files=0 size=0B > It's due to the fact that s3_tbl isn't a real table, it's a "test table" cr Oh ok, so that's pre-existing behaviour? I guess that's nbd, although I imagine it will confuse some other people. -- To view, visit http://gerrit.cloudera.org:8080/12282 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4b1b4a1bc1a24e9614e3b4dc5a61dc96d075d1c3 Gerrit-Change-Number: 12282 Gerrit-PatchSet: 6 Gerrit-Owner: Sahil Takiar <stak...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Sahil Takiar <stak...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Tue, 09 Apr 2019 21:40:10 +0000 Gerrit-HasComments: Yes
