Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/12975 )
Change subject: IMPALA-8391: [DOCS] ALTER TABLE RENAME now renames the underlying Kudu TABLE ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/12975/1/docs/topics/impala_tables.xml File docs/topics/impala_tables.xml: http://gerrit.cloudera.org:8080/#/c/12975/1/docs/topics/impala_tables.xml@302 PS1, Line 302: You can use <codeph>ALTER TABLE</codeph> to rename the Impala table change "<codeph>ALTER TABLE</codeph>" to "<codeph>ALTER TABLE <varname>[old_db_name.]old_table_name/varname> RENAME TO <varname>[new_db_name.]new_table_name/varname></codeph>"? Note the new behavior only applies to "managed" tables. Issuing a "ALTER TABLE..." on an external table will only rename the Impala table, the Kudu table will remain the same. http://gerrit.cloudera.org:8080/#/c/12975/1/docs/topics/impala_tables.xml@303 PS1, Line 303: and the underlying Kudu table. I would phrase this more like: you can use "ALTER TABLE..." to rename the Impala table, which will also rename the underlying Kudu table. http://gerrit.cloudera.org:8080/#/c/12975/1/docs/topics/impala_tables.xml@306 PS1, Line 306: You can use <codeph>ALTER TABLE <varname>impala_name</varname> SET I would re-organize this a bit to have two distinct sections: one for renaming Impala-Kudu managed tables and one for renaming Impala-Kudu external tables. For Impala-Kudu managed tables issuing an "ALTER TABLE ... RENAME ..." will rename both the Impala and the Kudu table. For Impala-Kudu external tables issuing an "ALTER TABLE ... RENAME ..." will rename just the Impala table. If a user wants to change the Kudu table that an Impala external table points to, they can use "ALTER TABLE ... SET TBLPROPERTIES('kudu.table.name' ...)". -- To view, visit http://gerrit.cloudera.org:8080/12975 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I704a0623a05166e5f636b6c1063e9feffb58e65b Gerrit-Change-Number: 12975 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni <arod...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Sahil Takiar <stak...@cloudera.com> Gerrit-Comment-Date: Wed, 10 Apr 2019 20:17:29 +0000 Gerrit-HasComments: Yes
