Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12989 )
Change subject: IMPALA-8365: Add test coverage for running Impala with Ranger on local catalog mode ...................................................................... Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/12989/2/tests/authorization/test_ranger.py File tests/authorization/test_ranger.py: http://gerrit.cloudera.org:8080/#/c/12989/2/tests/authorization/test_ranger.py@39 PS2, Line 39: --server-name=server1 --ranger_service_type=hive " : "--ranger_app_id=impala " : "--authorization_factory_class=" : "org.apache.impala.authorization.ranger.RangerAuthorizationFactory nit: define strings for all the config boiler plate? Used thrice in this file. -- To view, visit http://gerrit.cloudera.org:8080/12989 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib2bcd7876e569e505cae7cf623496dad2b66518b Gerrit-Change-Number: 12989 Gerrit-PatchSet: 2 Gerrit-Owner: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Austin Nobis <ano...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Thu, 11 Apr 2019 01:27:50 +0000 Gerrit-HasComments: Yes
