Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/12939 )
Change subject: IMPALA-8386: Fix incorrect equivalence conjuncts not treated as identity ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/12939/1/fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java File fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java: http://gerrit.cloudera.org:8080/#/c/12939/1/fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java@1175 PS1, Line 1175: Predicate<Expr> isIdentityPredicate = new Predicate<Expr>() { > Sorry, I found a bug that this will also remove original identity predicate Not a bug. The predicate "amount = amount" is correctly pushed down to the scan node. I just missed it... -- To view, visit http://gerrit.cloudera.org:8080/12939 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia87aa9db2de85f0716e4854a88727aad593773fa Gerrit-Change-Number: 12939 Gerrit-PatchSet: 2 Gerrit-Owner: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Thu, 11 Apr 2019 15:39:16 +0000 Gerrit-HasComments: Yes
