Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12530 )
Change subject: IMPALA-8158: Retrieve thrift profiles through Impyla 0.15.0 ...................................................................... Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/12530/8/be/src/service/impala-hs2-server.cc File be/src/service/impala-hs2-server.cc: http://gerrit.cloudera.org:8080/#/c/12530/8/be/src/service/impala-hs2-server.cc@693 PS8, Line 693: Status status = Status::Expected("Cancelled by client"); > I think we should fix the issue separately is all - it's subtle and I'd wan That makes sense, I added a loop to wait for the status to reach ERROR_STATE and filed IMPALA-8411 for the follow up work. I think it would be great if we could simplify the query state handling to make it easier to reason about. -- To view, visit http://gerrit.cloudera.org:8080/12530 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I769a99f0843297dd2b20f2f5b1a9046c97bb131e Gerrit-Change-Number: 12530 Gerrit-PatchSet: 8 Gerrit-Owner: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Sat, 13 Apr 2019 04:50:00 +0000 Gerrit-HasComments: Yes
