Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12991 )
Change subject: Initial support for recursive file listing within a partition ...................................................................... Patch Set 1: (7 comments) Generally looks good to me. http://gerrit.cloudera.org:8080/#/c/12991/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12991/1//COMMIT_MSG@7 PS1, Line 7: Initial support for recursive file listing within a partition nit: Create a jira, since the change is substantial? http://gerrit.cloudera.org:8080/#/c/12991/1/fe/src/main/java/org/apache/impala/common/FileSystemUtil.java File fe/src/main/java/org/apache/impala/common/FileSystemUtil.java: http://gerrit.cloudera.org:8080/#/c/12991/1/fe/src/main/java/org/apache/impala/common/FileSystemUtil.java@521 PS1, Line 521: if (isS3AFileSystem(fs)) { Do you happen to know if Azure has a similar optimization builtin? http://gerrit.cloudera.org:8080/#/c/12991/1/fe/src/main/java/org/apache/impala/common/FileSystemUtil.java@556 PS1, Line 556: private static class RecursingIterator implements RemoteIterator<FileStatus> { Should we add some unit tests for this? http://gerrit.cloudera.org:8080/#/c/12991/1/fe/src/main/java/org/apache/impala/common/FileSystemUtil.java@560 PS1, Line 560: private FileStatus curFile; nit:use _ for class members http://gerrit.cloudera.org:8080/#/c/12991/1/fe/src/main/java/org/apache/impala/common/FileSystemUtil.java@564 PS1, Line 564: startPath Preconditions.checkNotNull()? http://gerrit.cloudera.org:8080/#/c/12991/1/fe/src/main/java/org/apache/impala/common/FileSystemUtil.java@569 PS1, Line 569: curFile == nul mind adding docs? (what it means to be null) http://gerrit.cloudera.org:8080/#/c/12991/1/fe/src/test/java/org/apache/impala/catalog/FileMetadataLoaderTest.java File fe/src/test/java/org/apache/impala/catalog/FileMetadataLoaderTest.java: http://gerrit.cloudera.org:8080/#/c/12991/1/fe/src/test/java/org/apache/impala/catalog/FileMetadataLoaderTest.java@36 PS1, Line 36: Add an e-e test to read a bucketized hive table? -- To view, visit http://gerrit.cloudera.org:8080/12991 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9b151d7abb8443c0d9de0a0d82a9f13e07ad5109 Gerrit-Change-Number: 12991 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Anonymous Coward (486) Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Comment-Date: Sun, 14 Apr 2019 19:30:31 +0000 Gerrit-HasComments: Yes
