Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12959 )
Change subject: IMPALA-6718: Add support for column-level permissions on views ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/12959/5/fe/src/main/java/org/apache/impala/analysis/SelectStmt.java File fe/src/main/java/org/apache/impala/analysis/SelectStmt.java: http://gerrit.cloudera.org:8080/#/c/12959/5/fe/src/main/java/org/apache/impala/analysis/SelectStmt.java@576 PS5, Line 576: Stack<Expr> exprs = new Stack<>(); : exprs.addAll(getResultExprs()); : while (!exprs.isEmpty()) { : Expr expr = exprs.pop(); : if (!expr.getChildren().isEmpty()) { : exprs.addAll(expr.getChildren()); : } else if (expr instanceof SlotRef) { : SlotRef slotRef = (SlotRef) expr; : analyzer_.registerPrivReq(builder -> builder : .allOf(Privilege.SELECT) : .onColumn(view.getDb().getName(), view.getName(), : slotRef.getDesc().getLabel()) : .build()); : } Consider using TreeNode#collect()? -- To view, visit http://gerrit.cloudera.org:8080/12959 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If81e683212cba22cc0fa5fc091ec3c799fa33e14 Gerrit-Change-Number: 12959 Gerrit-PatchSet: 5 Gerrit-Owner: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Austin Nobis <ano...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Mon, 15 Apr 2019 17:40:30 +0000 Gerrit-HasComments: Yes