Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12927 )
Change subject: IMPALA-8363: Deny access when column masking or row filtering is enabled in Ranger ...................................................................... Patch Set 7: (4 comments) http://gerrit.cloudera.org:8080/#/c/12927/6/fe/src/main/java/org/apache/impala/authorization/AuthorizationChecker.java File fe/src/main/java/org/apache/impala/authorization/AuthorizationChecker.java: http://gerrit.cloudera.org:8080/#/c/12927/6/fe/src/main/java/org/apache/impala/authorization/AuthorizationChecker.java@129 PS6, Line 129: > Make it abstract? Done http://gerrit.cloudera.org:8080/#/c/12927/6/fe/src/main/java/org/apache/impala/authorization/ranger/RangerAuthorizationChecker.java File fe/src/main/java/org/apache/impala/authorization/ranger/RangerAuthorizationChecker.java: http://gerrit.cloudera.org:8080/#/c/12927/6/fe/src/main/java/org/apache/impala/authorization/ranger/RangerAuthorizationChecker.java@53 PS6, Line 53: // These are Ranger access types (privileges). : public static final String UPDATE_ACCESS_TYPE = "update"; : public static final String REFRESH_ACCESS_TYPE = "read"; > Document these? Done http://gerrit.cloudera.org:8080/#/c/12927/6/fe/src/main/java/org/apache/impala/authorization/ranger/RangerAuthorizationChecker.java@165 PS6, Line 165: getAuthorizable().getT > Move this throw inside authorizeColumnMask() (same below)? (Unless you are Done http://gerrit.cloudera.org:8080/#/c/12927/6/fe/src/main/java/org/apache/impala/authorization/ranger/RangerAuthorizationChecker.java@166 PS6, Line 166: request.getAuthorizable().getColumnName()); > Mention that Impala doesn't support column masking / row filtering yet? (sa Done -- To view, visit http://gerrit.cloudera.org:8080/12927 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If46b4bf24d916e4a4ea8a36ff4acfd95d5f45c8e Gerrit-Change-Number: 12927 Gerrit-PatchSet: 7 Gerrit-Owner: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Austin Nobis <ano...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Mon, 15 Apr 2019 18:13:34 +0000 Gerrit-HasComments: Yes
