Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12956 )
Change subject: IMPALA-8375: Add metrics for spill disk usage ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/12956/4/be/src/util/metrics.h File be/src/util/metrics.h: http://gerrit.cloudera.org:8080/#/c/12956/4/be/src/util/metrics.h@254 PS4, Line 254: /// maintains the current value. Note that since two separate atomics are used > I have made the suggested change. I was looking for a standard way to docum I'm open to the idea. We use the three-slash comments so that they're picked up by doxygen but don't use any other features. Some of the earlier authors didn't particularly like overly-structured javadoc-style comments - sometimes people get over-zealous and start over-documenting obvious parameters and return values. d...@impala.apache.org is a good place to float ideas like this, in the past we've made changes to the style guide based on informal consensus on the dev list and implemented them incrementally as code was touched. -- To view, visit http://gerrit.cloudera.org:8080/12956 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia1b3dd604c7234a8d8af34d70ca731544a46d298 Gerrit-Change-Number: 12956 Gerrit-PatchSet: 4 Gerrit-Owner: Abhishek Rawat <ara...@cloudera.com> Gerrit-Reviewer: Abhishek Rawat <ara...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Tue, 16 Apr 2019 22:15:38 +0000 Gerrit-HasComments: Yes
