Bharath Krishna has posted comments on this change. ( http://gerrit.cloudera.org:8080/13058 )
Change subject: IMPALA-8430: Fix flakiness in testCreateDropCreateDatabase ...................................................................... Patch Set 4: (1 comment) Thanks Vihang for the comment. Bharath, I have updated the patch accordingly. http://gerrit.cloudera.org:8080/#/c/13058/3/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java File fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java: http://gerrit.cloudera.org:8080/#/c/13058/3/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java@700 PS3, Line 700: // Adding sleep here to make sure that the CREATION_TIME is not same : // as the previous CREATE_TABLE operation, so as to trigger the filtering logic : // based on CREATION_TIME in DROP_TABLE event processing. This is currently a : // limitation : the DROP_TABLE event filtering expects that while processing events, : // the CREATION_TIME of two tables with same name won't have the same : // creation timestamp > I think it would be good to add the following comment in the DropTableEvent Done -- To view, visit http://gerrit.cloudera.org:8080/13058 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I30bf4535d54c9cd8d257b528dc7a1b42f106800d Gerrit-Change-Number: 13058 Gerrit-PatchSet: 4 Gerrit-Owner: Bharath Krishna <bhar...@cloudera.com> Gerrit-Reviewer: Anurag Mantripragada <anu...@cloudera.com> Gerrit-Reviewer: Bharath Krishna <bhar...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Comment-Date: Thu, 18 Apr 2019 03:02:20 +0000 Gerrit-HasComments: Yes
