Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/13065 )
Change subject: IMPALA-8293 (Part 1): Move SentryProxy out of CatalogServiceCatalog ...................................................................... Patch Set 4: Code-Review+2 (3 comments) Carry +2. http://gerrit.cloudera.org:8080/#/c/13065/3/fe/src/main/java/org/apache/impala/authorization/AuthorizationManager.java File fe/src/main/java/org/apache/impala/authorization/AuthorizationManager.java: http://gerrit.cloudera.org:8080/#/c/13065/3/fe/src/main/java/org/apache/impala/authorization/AuthorizationManager.java@128 PS3, Line 128: Performs a refresh authorization > nit: Mention what it actually does? Done http://gerrit.cloudera.org:8080/#/c/13065/3/fe/src/main/java/org/apache/impala/authorization/AuthorizationManager.java@130 PS3, Line 130: when resetVersions is true (used by INVALIDATE METADATA), : * catalog object versions will need to be incremented. : * @return {@link AuthorizationDelta} for the author > nit: swap this? When resetVersions is true, object versions are not increme Done http://gerrit.cloudera.org:8080/#/c/13065/3/fe/src/main/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManager.java File fe/src/main/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManager.java: http://gerrit.cloudera.org:8080/#/c/13065/3/fe/src/main/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManager.java@199 PS3, Line 199: // TODO: IMPALA-8293 (part 2) : return new AuthorizationDelta(); > nit: NotImplementedException...? Throwing an exception here will make `invalidate metadata` and `refresh authorization` broken when running with Ranger. -- To view, visit http://gerrit.cloudera.org:8080/13065 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3fa14abb09abfb4aaf6231d35114c0e121d6e568 Gerrit-Change-Number: 13065 Gerrit-PatchSet: 4 Gerrit-Owner: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Austin Nobis <ano...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Fri, 19 Apr 2019 16:44:02 +0000 Gerrit-HasComments: Yes
