Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/13047 )
Change subject: [acid] Disallow any operation on full acid table. ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/13047/2/fe/src/main/java/org/apache/impala/analysis/BaseTableRef.java File fe/src/main/java/org/apache/impala/analysis/BaseTableRef.java: http://gerrit.cloudera.org:8080/#/c/13047/2/fe/src/main/java/org/apache/impala/analysis/BaseTableRef.java@80 PS2, Line 80: transactional Can we change these strings to constants? transactional, transactional_properties, insert_only http://gerrit.cloudera.org:8080/#/c/13047/2/fe/src/main/java/org/apache/impala/analysis/BaseTableRef.java@84 PS2, Line 84: tableIsTransactional != null && tableIsTransactional.equalsIgnoreCase("true") nit, probably cleaner if we replace this by Boolean.parseBoolean(tableIsTransactional) -- To view, visit http://gerrit.cloudera.org:8080/13047 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifb92e5b691bf192980f2cc7d68c491bb1e8455ac Gerrit-Change-Number: 13047 Gerrit-PatchSet: 2 Gerrit-Owner: Sudhanshu Arora <sudhan...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Comment-Date: Tue, 23 Apr 2019 19:42:48 +0000 Gerrit-HasComments: Yes
