Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12939 )
Change subject: IMPALA-8386: Fix incorrect equivalence conjuncts not treated as identity ...................................................................... Patch Set 5: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/12939/4/testdata/workloads/functional-planner/queries/PlannerTest/inline-view.test File testdata/workloads/functional-planner/queries/PlannerTest/inline-view.test: http://gerrit.cloudera.org:8080/#/c/12939/4/testdata/workloads/functional-planner/queries/PlannerTest/inline-view.test@1705 PS4, Line 1705: # IMPALA-8386: test coverage for ORDER BY/LIMIT > The substitutions in other places are for ResultExprs which are from the or To be clear, i didn't think there was a bug in your code, just wanted to make sure we had some coverage of "interesting" cases. -- To view, visit http://gerrit.cloudera.org:8080/12939 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia87aa9db2de85f0716e4854a88727aad593773fa Gerrit-Change-Number: 12939 Gerrit-PatchSet: 5 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Tue, 23 Apr 2019 21:50:24 +0000 Gerrit-HasComments: Yes
