helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12977 )
Change subject: IMPALA-5351: Support storing column comment of kudu table ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/12977/3/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/12977/3/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@3896 PS3, Line 3896: if (!updateColumnComment(msTbl.getPartitionKeysIterator(), columnName, comment)) { > line too long (92 > 90) Done -- To view, visit http://gerrit.cloudera.org:8080/12977 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifb3b37eed364f12bdb3c1d7ef5be128f1475936c Gerrit-Change-Number: 12977 Gerrit-PatchSet: 3 Gerrit-Owner: helifu <hzhel...@corp.netease.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Thomas Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: helifu <hzhel...@corp.netease.com> Gerrit-Comment-Date: Thu, 25 Apr 2019 00:32:31 +0000 Gerrit-HasComments: Yes
