Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/12950 )
Change subject: IMPALA-8454 (part 1): Refactor file descriptor loading code ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/12950/5/fe/src/main/java/org/apache/impala/catalog/FileMetadataLoader.java File fe/src/main/java/org/apache/impala/catalog/FileMetadataLoader.java: http://gerrit.cloudera.org:8080/#/c/12950/5/fe/src/main/java/org/apache/impala/catalog/FileMetadataLoader.java@86 PS5, Line 86: "); > nit: worth including the partition name? (same with other logs) would rather not add code for this since it's just a developer-facing assertion. This shouldn't ever fire in real life -- To view, visit http://gerrit.cloudera.org:8080/12950 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I59edf493b9ba38be5f556b4795a7684d9c9e3a07 Gerrit-Change-Number: 12950 Gerrit-PatchSet: 5 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Sudhanshu Arora <sudhan...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Reviewer: Yongzhi Chen <yc...@cloudera.com> Gerrit-Comment-Date: Thu, 25 Apr 2019 20:50:42 +0000 Gerrit-HasComments: Yes
