Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/13095 )
Change subject: IMPALA-8444: Fix performance regression when building privilege name ...................................................................... Patch Set 8: (4 comments) Thanks for the changes! Few more missing bits. http://gerrit.cloudera.org:8080/#/c/13095/8//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/13095/8//COMMIT_MSG@8 PS8, Line 8: The commit message could also reflect that there are also some fixes related to case sensitivity. http://gerrit.cloudera.org:8080/#/c/13095/8//COMMIT_MSG@33 PS8, Line 33: While fixing this, I found a bug where Principal : stores the PrincipalPrivilege in case insensitive way. This is true for : all privilege scopes, except URI. This patch fixes the issue by storing : URI privilege in a case sensitive manner. Is this still correct? http://gerrit.cloudera.org:8080/#/c/13095/8/fe/src/main/java/org/apache/impala/catalog/CatalogObjectCache.java File fe/src/main/java/org/apache/impala/catalog/CatalogObjectCache.java: http://gerrit.cloudera.org:8080/#/c/13095/8/fe/src/main/java/org/apache/impala/catalog/CatalogObjectCache.java@158 PS8, Line 158: } Is there some kind of whitespace change here? http://gerrit.cloudera.org:8080/#/c/13095/2/fe/src/main/java/org/apache/impala/catalog/Principal.java File fe/src/main/java/org/apache/impala/catalog/Principal.java: http://gerrit.cloudera.org:8080/#/c/13095/2/fe/src/main/java/org/apache/impala/catalog/Principal.java@63 PS2, Line 63: */ : public boolean addPrivilege(PrincipalPrivilege privilege) { : return principalPrivileges_.add(privilege); > I decided to change the whole thing to make the cache stores the privilege Can you add tests for the bugs that were fixed? -- To view, visit http://gerrit.cloudera.org:8080/13095 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I942d9b55f07c8972f69e532567d9b7d80fceb6e5 Gerrit-Change-Number: 13095 Gerrit-PatchSet: 8 Gerrit-Owner: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Thu, 25 Apr 2019 22:12:03 +0000 Gerrit-HasComments: Yes
