Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13050 )
Change subject: IMPALA-966: Type errors are attributed to wrong expression with insert ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/13050/2/fe/src/main/java/org/apache/impala/analysis/InsertStmt.java File fe/src/main/java/org/apache/impala/analysis/InsertStmt.java: http://gerrit.cloudera.org:8080/#/c/13050/2/fe/src/main/java/org/apache/impala/analysis/InsertStmt.java@690 PS2, Line 690: if (queryStmt_.widestExprs_ == null || queryStmt_.widestExprs_.size() != selectListExprs.size()) { line too long (104 > 90) http://gerrit.cloudera.org:8080/#/c/13050/2/fe/src/main/java/org/apache/impala/analysis/StatementBase.java File fe/src/main/java/org/apache/impala/analysis/StatementBase.java: http://gerrit.cloudera.org:8080/#/c/13050/2/fe/src/main/java/org/apache/impala/analysis/StatementBase.java@195 PS2, Line 195: * line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/13050/2/fe/src/main/java/org/apache/impala/analysis/StatementBase.java@204 PS2, Line 204: Expr srcExpr, boolean strictDecimal, Expr widestTypeSrcExpr) throws AnalysisException { line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/13050/2/fe/src/main/java/org/apache/impala/analysis/StatementBase.java@224 PS2, Line 224: dstTableName, widestTypeSrcExpr.toSql(), srcExprType.toSql(), dstColType.toSql(), line too long (91 > 90) -- To view, visit http://gerrit.cloudera.org:8080/13050 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I88718fc2cbe1a492165435a542fd2d91d8693a39 Gerrit-Change-Number: 13050 Gerrit-PatchSet: 2 Gerrit-Owner: Alice Fan <fan...@gmail.com> Gerrit-Reviewer: Alice Fan <fan...@gmail.com> Gerrit-Reviewer: Anonymous Coward <xiaom...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Paul Rogers <prog...@cloudera.com> Gerrit-Comment-Date: Fri, 26 Apr 2019 00:00:47 +0000 Gerrit-HasComments: Yes
