Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13131 )
Change subject: IMPALA-8463: fix skip.header.line.count on local catalog ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/13131/2/fe/src/main/java/org/apache/impala/catalog/FeFsTable.java File fe/src/main/java/org/apache/impala/catalog/FeFsTable.java: http://gerrit.cloudera.org:8080/#/c/13131/2/fe/src/main/java/org/apache/impala/catalog/FeFsTable.java@501 PS2, Line 501: > line too long (91 > 90) Done http://gerrit.cloudera.org:8080/#/c/13131/1/fe/src/main/java/org/apache/impala/catalog/local/LocalFsTable.java File fe/src/main/java/org/apache/impala/catalog/local/LocalFsTable.java: http://gerrit.cloudera.org:8080/#/c/13131/1/fe/src/main/java/org/apache/impala/catalog/local/LocalFsTable.java@524 PS1, Line 524: org.apache.hadoop.hive.metastore.api.Table msTbl = getMetaStoreTable(); > Can we just move the code from HdfsTable.java into FeFsTable.Utils and call Done -- To view, visit http://gerrit.cloudera.org:8080/13131 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3957b3661574c356a14197e8829abbed92028a1a Gerrit-Change-Number: 13131 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Fri, 26 Apr 2019 20:43:50 +0000 Gerrit-HasComments: Yes
