Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13005 )
Change subject: IMPALA-8369 : Impala should be able to interoperate with Hive 3.1.0 ...................................................................... Patch Set 11: (26 comments) http://gerrit.cloudera.org:8080/#/c/13005/11/bin/impala-config.sh File bin/impala-config.sh: http://gerrit.cloudera.org:8080/#/c/13005/11/bin/impala-config.sh@181 PS11, Line 181: # When USE_CDP_HIVE is set we use the latest hive version available to deply in minicluster line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/13005/11/bin/impala-config.sh@185 PS11, Line 185: export HIVE_METASTORE_THRIFT_DIR=$CDP_COMPONENTS_HOME/apache-hive-${IMPALA_HIVE_VERSION}-src/standalone-metastore/src/main/thrift line too long (131 > 90) http://gerrit.cloudera.org:8080/#/c/13005/11/bin/impala-config.sh@204 PS11, Line 204: export HIVE_HOME="$IMPALA_TOOLCHAIN/cdh_components-${CDH_BUILD_NUMBER}/hive-${IMPALA_HIVE_VERSION}" line too long (101 > 90) http://gerrit.cloudera.org:8080/#/c/13005/11/bin/impala-config.sh@205 PS11, Line 205: export HIVE_METASTORE_THRIFT_DIR=$CDH_COMPONENTS_HOME/hive-${IMPALA_HIVE_VERSION}/src/metastore/if line too long (100 > 90) http://gerrit.cloudera.org:8080/#/c/13005/11/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java: http://gerrit.cloudera.org:8080/#/c/13005/11/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@1073 PS11, Line 1073: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/13005/11/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@1169 PS11, Line 1169: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/13005/11/fe/src/main/java/org/apache/impala/service/MetadataOp.java File fe/src/main/java/org/apache/impala/service/MetadataOp.java: http://gerrit.cloudera.org:8080/#/c/13005/11/fe/src/main/java/org/apache/impala/service/MetadataOp.java@319 PS11, Line 319: MetastoreShim.mapToInternalTableType(table.getMetaStoreTable().getTableType()); line too long (97 > 90) http://gerrit.cloudera.org:8080/#/c/13005/11/testdata/bin/run-hive-server.sh File testdata/bin/run-hive-server.sh: http://gerrit.cloudera.org:8080/#/c/13005/11/testdata/bin/run-hive-server.sh@66 PS11, Line 66: export HIVE_METASTORE_HADOOP_OPTS="-verbose:class -Xdebug -Xrunjdwp:transport=dt_socket,server=y,suspend=n,address=30010" line too long (121 > 90) http://gerrit.cloudera.org:8080/#/c/13005/11/tests/authorization/test_owner_privileges.py File tests/authorization/test_owner_privileges.py: http://gerrit.cloudera.org:8080/#/c/13005/11/tests/authorization/test_owner_privileges.py@103 PS11, Line 103: ) flake8: E501 line too long (91 > 90 characters) http://gerrit.cloudera.org:8080/#/c/13005/11/tests/authorization/test_owner_privileges.py@179 PS11, Line 179: = flake8: E501 line too long (93 > 90 characters) http://gerrit.cloudera.org:8080/#/c/13005/11/tests/authorization/test_owner_privileges.py@182 PS11, Line 182: = flake8: E501 line too long (93 > 90 characters) http://gerrit.cloudera.org:8080/#/c/13005/11/tests/authorization/test_owner_privileges.py@186 PS11, Line 186: ) flake8: E501 line too long (91 > 90 characters) http://gerrit.cloudera.org:8080/#/c/13005/11/tests/authorization/test_owner_privileges.py@193 PS11, Line 193: , flake8: E501 line too long (91 > 90 characters) http://gerrit.cloudera.org:8080/#/c/13005/11/tests/authorization/test_owner_privileges.py@213 PS11, Line 213: ) flake8: E501 line too long (91 > 90 characters) http://gerrit.cloudera.org:8080/#/c/13005/11/tests/authorization/test_owner_privileges.py@226 PS11, Line 226: ) flake8: E501 line too long (91 > 90 characters) http://gerrit.cloudera.org:8080/#/c/13005/11/tests/authorization/test_owner_privileges.py@236 PS11, Line 236: ) flake8: E501 line too long (91 > 90 characters) http://gerrit.cloudera.org:8080/#/c/13005/11/tests/authorization/test_owner_privileges.py@282 PS11, Line 282: _ flake8: E501 line too long (100 > 90 characters) http://gerrit.cloudera.org:8080/#/c/13005/11/tests/authorization/test_owner_privileges.py@287 PS11, Line 287: t flake8: E501 line too long (101 > 90 characters) http://gerrit.cloudera.org:8080/#/c/13005/11/tests/authorization/test_owner_privileges.py@293 PS11, Line 293: 2 flake8: E501 line too long (92 > 90 characters) http://gerrit.cloudera.org:8080/#/c/13005/11/tests/authorization/test_owner_privileges.py@355 PS11, Line 355: _ flake8: E501 line too long (100 > 90 characters) http://gerrit.cloudera.org:8080/#/c/13005/11/tests/authorization/test_owner_privileges.py@360 PS11, Line 360: t flake8: E501 line too long (101 > 90 characters) http://gerrit.cloudera.org:8080/#/c/13005/11/tests/authorization/test_owner_privileges.py@364 PS11, Line 364: 2 flake8: E501 line too long (92 > 90 characters) http://gerrit.cloudera.org:8080/#/c/13005/11/tests/authorization/test_owner_privileges.py@368 PS11, Line 368: ) flake8: E501 line too long (91 > 90 characters) http://gerrit.cloudera.org:8080/#/c/13005/11/tests/authorization/test_owner_privileges.py@412 PS11, Line 412: t flake8: E501 line too long (101 > 90 characters) http://gerrit.cloudera.org:8080/#/c/13005/11/tests/authorization/test_owner_privileges.py@421 PS11, Line 421: i flake8: E501 line too long (102 > 90 characters) http://gerrit.cloudera.org:8080/#/c/13005/11/tests/common/sentry_cache_test_suite.py File tests/common/sentry_cache_test_suite.py: http://gerrit.cloudera.org:8080/#/c/13005/11/tests/common/sentry_cache_test_suite.py@83 PS11, Line 83: } flake8: E501 line too long (92 > 90 characters) -- To view, visit http://gerrit.cloudera.org:8080/13005 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I45a4dadbdfe30a02f722dbd917a49bc182fc6436 Gerrit-Change-Number: 13005 Gerrit-PatchSet: 11 Gerrit-Owner: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Sudhanshu Arora <sudhan...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Sat, 27 Apr 2019 02:17:43 +0000 Gerrit-HasComments: Yes
