Fredy Wijaya has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/12977 )

Change subject: IMPALA-5351: Support storing column comment of kudu table
......................................................................


Patch Set 8:

(1 comment)

> Patch Set 8:
>
> Build Failed
> 
> https://jenkins.impala.io/job/gerrit-code-review-checks/2951/ : Initial code 
> review checks failed. See linked job for details on the failure.

Looks like some compilation error:
02:30:00 [ERROR] COMPILATION ERROR :
02:30:00 [ERROR] 
/home/ubuntu/tmp.Myz4JNT6Cp/fe/src/main/java/org/apache/impala/catalog/KuduColumn.java:[88,32]
 cannot find symbol
02:30:00 [ERROR] 
/home/ubuntu/tmp.Myz4JNT6Cp/fe/src/main/java/org/apache/impala/catalog/KuduColumn.java:[88,67]
 cannot find symbol
02:30:00 [ERROR] 
/home/ubuntu/tmp.Myz4JNT6Cp/fe/src/main/java/org/apache/impala/service/KuduCatalogOpExecutor.java:[135,10]
 cannot find symbol
02:30:00 [ERROR] 
/home/ubuntu/tmp.Myz4JNT6Cp/fe/src/main/java/org/apache/impala/service/KuduCatalogOpExecutor.java:[299,23]
 cannot find symbol
02:30:00 [ERROR] 
/home/ubuntu/tmp.Myz4JNT6Cp/fe/src/main/java/org/apache/impala/service/KuduCatalogOpExecutor.java:[299,58]
 cannot find symbol
02:30:00 [ERROR] 
/home/ubuntu/tmp.Myz4JNT6Cp/fe/src/main/java/org/apache/impala/service/KuduCatalogOpExecutor.java:[504,24]
 cannot find symbol
02:30:00 [INFO] BUILD FAILURE
02:30:00 [ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-compiler-plugin:3.3:compile (default-compile) on 
project impala-frontend: Compilation failure: Compilation failure:
02:30:00 [ERROR] 
/home/ubuntu/tmp.Myz4JNT6Cp/fe/src/main/java/org/apache/impala/catalog/KuduColumn.java:[88,32]
 cannot find symbol
02:30:00 [ERROR] symbol:   method getComment()
02:30:00 [ERROR] location: variable colSchema of type 
org.apache.kudu.ColumnSchema
02:30:00 [ERROR] 
/home/ubuntu/tmp.Myz4JNT6Cp/fe/src/main/java/org/apache/impala/catalog/KuduColumn.java:[88,67]
 cannot find symbol
02:30:00 [ERROR] symbol:   method getComment()
02:30:00 [ERROR] location: variable colSchema of type 
org.apache.kudu.ColumnSchema
02:30:00 [ERROR] 
/home/ubuntu/tmp.Myz4JNT6Cp/fe/src/main/java/org/apache/impala/service/KuduCatalogOpExecutor.java:[135,10]
 cannot find symbol
02:30:00 [ERROR] symbol:   method comment(java.lang.String)
02:30:00 [ERROR] location: variable csb of type 
org.apache.kudu.ColumnSchema.ColumnSchemaBuilder
02:30:00 [ERROR] 
/home/ubuntu/tmp.Myz4JNT6Cp/fe/src/main/java/org/apache/impala/service/KuduCatalogOpExecutor.java:[299,23]
 cannot find symbol
02:30:00 [ERROR] symbol:   method getComment()
02:30:00 [ERROR] location: variable colSchema of type 
org.apache.kudu.ColumnSchema
02:30:00 [ERROR] 
/home/ubuntu/tmp.Myz4JNT6Cp/fe/src/main/java/org/apache/impala/service/KuduCatalogOpExecutor.java:[299,58]
 cannot find symbol
02:30:00 [ERROR] symbol:   method getComment()
02:30:00 [ERROR] location: variable colSchema of type 
org.apache.kudu.ColumnSchema
02:30:00 [ERROR] 
/home/ubuntu/tmp.Myz4JNT6Cp/fe/src/main/java/org/apache/impala/service/KuduCatalogOpExecutor.java:[504,24]
 cannot find symbol
02:30:00 [ERROR] symbol:   method 
changeComment(java.lang.String,java.lang.String)
02:30:00 [ERROR] location: variable alterTableOptions of type 
org.apache.kudu.client.AlterTableOptions
02:30:00 [ERROR] -> [Help 1]
02:30:00 [ERROR]
02:30:00 [ERROR] To see the full stack trace of the errors, re-run Maven with 
the -e switch.
02:30:00 [ERROR] Re-run Maven using the -X switch to enable full debug logging.
02:30:00 [ERROR]
02:30:00 [ERROR] For more information about the errors and possible solutions, 
please read the following articles:
02:30:00 [ERROR] [Help 1] 
http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException

http://gerrit.cloudera.org:8080/#/c/12977/8/tests/metadata/test_ddl.py
File tests/metadata/test_ddl.py:

http://gerrit.cloudera.org:8080/#/c/12977/8/tests/metadata/test_ddl.py@737
PS8, Line 737:     self.client.execute("drop table {0}".format(table))
Instead of dropping, we can just create two different tables for the first one 
and second one. They will be automatically deleted after the test completes.



--
To view, visit http://gerrit.cloudera.org:8080/12977
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb3b37eed364f12bdb3c1d7ef5be128f1475936c
Gerrit-Change-Number: 12977
Gerrit-PatchSet: 8
Gerrit-Owner: helifu <hzhel...@corp.netease.com>
Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <tmarsh...@cloudera.com>
Gerrit-Reviewer: helifu <hzhel...@corp.netease.com>
Gerrit-Comment-Date: Sun, 28 Apr 2019 04:56:19 +0000
Gerrit-HasComments: Yes

Reply via email to